Fix auto refresh token logic to ensure timely token renewal#442
Merged
NipuniBhagya merged 5 commits intoasgardeo:mainfrom Apr 8, 2026
Merged
Fix auto refresh token logic to ensure timely token renewal#442NipuniBhagya merged 5 commits intoasgardeo:mainfrom
NipuniBhagya merged 5 commits intoasgardeo:mainfrom
Conversation
brionmario
reviewed
Apr 8, 2026
|
|
||
| if (isAlreadySignedIn) { | ||
| await updateSession(); | ||
| await asgardeo.startAutoRefreshToken(); |
Member
There was a problem hiding this comment.
Shall we add a try catch and throw a warn log if this fails.
Fixes an error in the auto refresh token logic.
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
brionmario
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request fixes an error in the auto refresh token logic for the
@asgardeo/browserpackage. The update ensures that access tokens are refreshed at the correct time, preventing premature or missed refreshes.Improvements to token refresh logic:
spa-helper.tsto use the token's absolute expiry time and a 10-second buffer, ensuring the refresh happens just before expiration. The logic now checks for the presence ofcreated_atandexpires_inbefore proceeding, and immediately refreshes the token if it's already expired or about to expire.Changelog update:
@asgardeo/browser.Related Issues
Checklist
Security checks